Nhse o32 orkv.i50 emptymerge #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All CRDT updates at the coordinator include a merge with and empty CRDT before the update is applied. So the merge function should be optimised to avoid extra work should the RHS CRDT be empty.
Dialyzer complained, but it was important that the variables were matched (though ignored).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimises the merging of a set for the case when the Right-Hand Set is empty.
When updating a set, there is always first a merge with an empty set, followed by an update to add a member or members. So optimising a merge with an empty set will improve performance.
OpenRiak/riak_kv#50 (comment)